Incorporate CI and ARM feedback from azure-rest-api-specs to v2024-08-12-preview API #3727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
83f43ef
to
7a69b14
Compare
tsatam
previously approved these changes
Jul 31, 2024
github-actions
bot
added
needs-rebase
|
Please rebase pull request. |
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
70164c7
to
74088f9
Compare
cadenmarchese
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
AldoFusterTurpin and
kimorris27
as code owners
bennerv
reviewed
Sep 26, 2024
| out.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ResourceID = oc.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ResourceID | ||
| out.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ClientID = oc.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ClientID | ||
| out.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ObjectID = oc.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[i].ObjectID | ||
| for k := range oc.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities { |
There was a problem hiding this comment.
This logic should be able to be simplified similar to how the tags are formed, isn't it?
for k, v := range oc.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities {
out.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[k].ClientId == v.ClientId
...
There was a problem hiding this comment.
I tried that first, but was unable to get it to compile:
cannot assign to struct field out.Properties.PlatformWorkloadIdentityProfile.PlatformWorkloadIdentities[k].ResourceID in map
etc...
this was wrong in the readme
top level fields must not have additionalproperties
…edIdentity type from the API
it was requested that we use the latest version of common types. This involves some changes to our examples to match the UUID expected.
defined in common-types/v6
avoids python client generation issues
cadenmarchese
force-pushed
the
cadenmarchese/ARO-4382/api-changes-1
branch
from
6675b4e
to
e7e466f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
https://issues.redhat.com/browse/ARO-4382
What this PR does / why we need it:
I opened up a PR to azure-rest-api-specs with our new API version: Azure/azure-rest-api-specs#30004
These are the changes that were required to unblock CI / resolve breaking change and other CI failures.
Test plan for issue:
Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?